Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: drop Location.type_index #578

Merged
merged 5 commits into from
Sep 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -325,41 +325,38 @@
}

// Describes function and line table debug information.
message Location {
// Unique nonzero id for the location. A profile could use
// instruction addresses or any integer sequence as ids. [deprecated]
uint64 id = 1;
// The index of the corresponding profile.Mapping for this location.
// It can be unset if the mapping is unknown or not applicable for
// this profile type.
uint64 mapping_index = 2;
// The instruction address for this location, if available. It
// should be within [Mapping.memory_start...Mapping.memory_limit]
// for the corresponding mapping. A non-leaf address may be in the
// middle of a call instruction. It is up to display tools to find
// the beginning of the instruction if necessary.
uint64 address = 3;
// Multiple line indicates this location has inlined functions,
// where the last entry represents the caller into which the
// preceding entries were inlined.
//
// E.g., if memcpy() is inlined into printf:
// line[0].function_name == "memcpy"
// line[1].function_name == "printf"
repeated Line line = 4;
// Provides an indication that multiple symbols map to this location's
// address, for example due to identical code folding by the linker. In that
// case the line information above represents one of the multiple
// symbols. This field must be recomputed when the symbolization state of the
// profile changes.
bool is_folded = 5;

// Type of frame (e.g. kernel, native, python, hotspot, php). Index into string table.
int64 type_index = 6;

// References to attributes in Profile.attribute_table. [optional]
repeated uint64 attributes = 7;
christos68k marked this conversation as resolved.
Show resolved Hide resolved
}

Check failure on line 359 in opentelemetry/proto/profiles/v1experimental/pprofextended.proto

View workflow job for this annotation

GitHub Actions / breaking-change

Buf detected breaking change FIELD_NO_DELETE_UNLESS_NUMBER_RESERVED

Previously present field "6" with name "type_index" on message "Location" was deleted without reserving the number "6".

// Details a specific line in a source code, linked to a function.
message Line {
Expand Down
Loading