Disconnect gRPC client stub when shutting down OTLPSpanExporter #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xmakro Thanks for the PR, please add a CHANGELOG entry. Can this be tested? |
|
I added the change log. I don't see a good way to test the disconnect, since it is the gRPC channel that gets disconnected, but these channels are not exposed on the gRPC server side api. |
xrmx
reviewed
Dec 24, 2024
| @@ -360,6 +360,7 @@ def shutdown(self, timeout_millis: float = 30_000, **kwargs) -> None: | |||
| # wait for the last export if any | |||
| self._export_lock.acquire(timeout=timeout_millis / 1e3) | |||
| self._shutdown = True | |||
| self._client = None | |||
There was a problem hiding this comment.
Wondering if storing the channel in __init__ and call here its close() method would work too
There was a problem hiding this comment.
Yes good idea that is cleaner. I verified that this works as well and changed the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the gRPC client will stay connected past the shutdown