fix: ActiveJob::Handlers.unsubscribe (#1078)

Fix ActiveJob::Handlers.unsubscribe
open-telemetry · Jul 22, 2024 · 8b9aba3 · 8b9aba3
1 parent 246fc10
commit 8b9aba3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/instrumentation/active_job/lib/opentelemetry/instrumentation/active_job/handlers.rb b/instrumentation/active_job/lib/opentelemetry/instrumentation/active_job/handlers.rb
@@ -64,7 +64,7 @@ def subscribe
         # Removes Event Handler Subscriptions for ActiveJob notifications
         # @note this method is not thread-safe and should not be used in a multi-threaded context
         def unsubscribe
-          @subscriptions&.each { |subscriber| ActiveSupport::Notifications.unsubscribe(subscriber) }
+          @subscriptions&.each { |subscriber| ::ActiveSupport::Notifications.unsubscribe(subscriber) }
           @subscriptions = nil
         end
       end

diff --git a/instrumentation/active_job/test/opentelemetry/instrumentation/active_job/handlers_test.rb b/instrumentation/active_job/test/opentelemetry/instrumentation/active_job/handlers_test.rb
@@ -50,4 +50,14 @@
       _(MixedArgsJob.perform_now('arg1', 'arg2', keyword2: :keyword2)).must_be_nil # Make sure this runs without raising an error
     end
   end
+
+  describe 'usage' do
+    it 'can unsubscribe' do
+      _(OpenTelemetry::Instrumentation::ActiveJob::Handlers.instance_variable_get(:@subscriptions)).wont_be_empty
+
+      OpenTelemetry::Instrumentation::ActiveJob::Handlers.unsubscribe
+
+      _(OpenTelemetry::Instrumentation::ActiveJob::Handlers.instance_variable_get(:@subscriptions)).must_be_nil
+    end
+  end
 end