-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add grpc instrumentation #1164
feat: add grpc instrumentation #1164
Conversation
See <https://github.com/hibachrach/opentelemetry-instrumentation-grpc/> for previous git history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this, @hibachrach! I'm excited to take a deeper look!
As far as I know, this is the first time we've brought a gem into contrib that was originally created outside the repository. There's a few things about consistency in tooling that I'd like to talk about with the SIG as part of the review. More soon.
Sounds good--happy to align to y'all in any way; no attachment to anything in this PR as it stands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hibachrach! Thanks for your patience! Great to hear you're happy to align with the rest of the repo! 😄
The main differences we see between your gRPC gem and the rest of the instrumentation are:
- Rspec instead of minitest
- Standard instead of Rubocop
- Changelog format
- Unique code of conduct
- RBS
We also want to add this gem to the GitHub actions for this repo to run tests and release the gem.
The SIG had two ideas about how to make the alignment work:
- Merge your PR as-is and the approvers/maintainers will submit subsequent PRs to update the tooling to make it compatible with our CI and more closely mirror the other gems.
- Make the updates as part of this PR, merging it in once everything is aligned. The approvers/maintainers might make branches off yours to simplify the movement, or we could describe the changes to you and let you take care of them.
I know you've mentioned you have limited time to work on this, so let us know how you'd prefer to move forward. We're really grateful for the work you've done to create the gem and for bringing it into contrib. We want to make things as smooth as we can for you.
p.s. - I left a few suggestions related to some Gruf leftovers I found when looking this over!
instrumentation/grpc/opentelemetry-instrumentation-grpc.gemspec
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions to help the markdown-related CI actions pass!
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Hello @hibachrach and @kaylareopelle I’d like to express my interest in contributing to this PR. Of course, @hibachrach has the precedence in responding to the PR review. My potential contribution could involve either:
Let me know how I can best assist! |
Go for it! My personal life has been quite busy so I haven't had the opportunity to contribute here. |
@michal-kazmierczak, thanks for expressing your interest! And thank you, @hibachrach, for chiming in! @michal-kazmierczak - to make things easier for you to contribute, I think we should merge this PR, knowing that the gem isn't ready for OpenTelemetry to release just yet. I'll open up an issue tomorrow with more detailed steps on what we need to take care of before we can release a new version under the open-telemetry org. If any maintainers/approvers disagree with this approach, please let me know! |
I'm ok with that as long as the unfinished gem isn't releasable or a dependency of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We keep hitting Markdown Link Check failures for different links that are actually up and reporting just fine (ex: https://opensource.org/licenses/MIT). It seems like there's a timeout issue with the action itself. Instead of trying to run the failed job again, I'm going to consider this good enough and merge in the PR.
See https://github.com/hibachrach/opentelemetry-instrumentation-grpc/ for previous git history
Closes #1041