fix: ActiveJob Propagate baggage information properly when performing #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoheyk
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
yoheyk
commented
Oct 24, 2024
| @@ -225,6 +210,21 @@ | |||
| _(process_span.links[0].span_context.trace_id).must_equal(publish_span.trace_id) | |||
| _(process_span.links[0].span_context.span_id).must_equal(publish_span.span_id) | |||
| end | |||
|
|
|||
| it 'propagates baggage' do | |||
There was a problem hiding this comment.
this test case needs to be run with an async queue adapter
|
we need to do more than just reverting #1018 |
arielvalentin
approved these changes
Oct 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading ActiveJob instrumentation to
0.7.2, we have noticed that baggage information is not propagating properly via ActiveJob.Looks like the deletion of this line is causing the issue (We are using the
childpropagation style):https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/1018/files#diff-bc60a254cc5ccc8843a524d0eb4c8[…]218817496946fa815a22a39a010b5ddL39
Passing the extracted context as the parent for the consumer context seems to resolve this issue.