test: loosen the koala pin to ~> 3.0 #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-kazmierczak
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
michal-kazmierczak
changed the title
arielvalentin
changed the title
|
@michal-kazmierczak I am rescoping this to |
arielvalentin
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
~> 3.0.0pin of the koala lib restricted the instrumentation to always be tested against a (7-year old) 3.0.x version. I think it's viable to loosen this restriction and enable testing against3.xversion.This change also resolves the issue of a failing pipeline, as version
3.0.0is incompatible with thefaraday-multipart 1.1.0dependency. For reference, here’s an example of the failure: https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/12399050526/job/34613192801