-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: suppress deprecation warning in Rdkafka Instrumentation #884
Merged
arielvalentin
merged 9 commits into
open-telemetry:main
from
yoheyk:rdkafka-suppress-deprecation-warning
Apr 5, 2024
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
369fb4a
fix: suppress deprecation warning in Rdkafka Instrumentation
yoheyk 661cd67
memoize getter
yoheyk 21e4a43
Use constant
yoheyk f371f50
Merge branch 'main' into rdkafka-suppress-deprecation-warning
yoheyk 161e322
rubocop fix
yoheyk fff7df5
Merge branch 'main' into rdkafka-suppress-deprecation-warning
arielvalentin 05f7fbf
Merge branch 'main' into rdkafka-suppress-deprecation-warning
arielvalentin 208e3ba
Merge branch 'main' into rdkafka-suppress-deprecation-warning
arielvalentin a29c7ff
Merge branch 'main' into rdkafka-suppress-deprecation-warning
arielvalentin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very sorry for the delayed review.
Is this something that can be checked at installation time as opposed to when the worker processes the first message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about this? 21e4a43