Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add instrumentation support for action mailer #887
feat: add instrumentation support for action mailer #887
Changes from all commits
34d8f7e
d8690e0
97c2912
d3fbccd
ebfc9d4
561e3d9
d1369fa
eebca4d
dc3eded
bb76bcd
02217ce
0c6bdef
e0e32d1
e916022
faa4dc6
7baf1c3
9a2aa0f
fc1ae28
aaaffcf
3bbfa84
402278c
05b2b82
6f795e5
1cb3d84
b04512c
103aeea
76f8a8a
b313efc
454faf9
6def1ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether to open a new issue, but wanted to try here first.
We had added instrumentation for
ActionMailer
ourselves usingOpenTelemetry::Instrumentation::ActiveSupport.subscribe
, but had addedprocess.action_mailer
as well. The span itself doesn't have interesting attributes but it helps wrap everything necessary to render the email in a common span. We find this very useful. For example:Helps see how long it takes to render the email vs actually deliver it:
Would you be open to adding this as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally add functionality based on our user need and in many cases we tend to add features that we (maintainers) regularly use in production.
We are happy to review any contributions you'd like to submit to the community and look forward to your help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! I'll look into it!