Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add instrumentation support for action mailer #887
feat: add instrumentation support for action mailer #887
Changes from 18 commits
34d8f7e
d8690e0
97c2912
d3fbccd
ebfc9d4
561e3d9
d1369fa
eebca4d
dc3eded
bb76bcd
02217ce
0c6bdef
e0e32d1
e916022
faa4dc6
7baf1c3
9a2aa0f
fc1ae28
aaaffcf
3bbfa84
402278c
05b2b82
6f795e5
1cb3d84
b04512c
103aeea
76f8a8a
b313efc
454faf9
6def1ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intent of this code block to show you can get the ActionMailer instrumentation from the solo
opentelemetry-instrumentation-action_mailer
gem or theopentelemetry-instrumentation-rails
gem?If so, I think the
opentelemetry-instrumentation-rails.gemspec
should be updated to addopentelemetry-instrumentation-action_mailer
as a dependency.It might also be helpful to add a comment within the code block that describes the two options more clearly. It could read something like:
With how it's currently written, I think I have to install both gems to get ActionMailer instrumentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
I think it's better to have action_mailer gem released on rubygems then include rails (also for instrumentation-all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this saying the following attributes are on the
action_mailer deliver
spans?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should incorporate "notifications payload" somewhere into this sentence to make it clear that's where the attributes are coming from.
Maybe:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.