Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-ci): upgrade conventional commit check #923

Conversation

robbkidd
Copy link
Member

@robbkidd robbkidd commented Apr 2, 2024

Fixes Conventional Commit checking in CI.

Dependabot creates PRs with a chore(deps-dev): prefix when it is updating development-only dependencies. The version of the GitHub Action we're using—dev-build-deploy/[email protected][1]—to validate commit prefixes balks at the hyphen. v1.4.0 includes an update[2] that recognizes scopes that contain hyphens.

[1] https://github.com/dev-build-deploy/commit-me/tree/v1.3.1
[2] dev-build-deploy/commit-me@38d4cb0

[email protected] includes an update[1] that recognizes scopes that
contain hyphens.

[1] dev-build-deploy/commit-me@38d4cb0
@robbkidd robbkidd force-pushed the update-conventional-commit-checker branch from 16a5748 to fbee738 Compare April 2, 2024 20:48
@robbkidd
Copy link
Member Author

robbkidd commented Apr 2, 2024

Seems happy on this PR with a prefix containing a hyphen.

@arielvalentin arielvalentin merged commit addc2f3 into open-telemetry:main Apr 2, 2024
50 checks passed
@robbkidd robbkidd self-assigned this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants