Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud_run_job to MonitoredResource #101

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

fiadliel
Copy link
Contributor

Fixes #100

Changes

Adds MonitoredResource::CloudRunJob which adds the appropriate labels for the cloud_run_job monitored resource type.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@fiadliel fiadliel requested a review from a team August 13, 2024 07:45
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 56.2%. Comparing base (56a6f45) to head (bef4d46).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-stackdriver/src/lib.rs 0.0% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #101     +/-   ##
=======================================
+ Coverage   52.3%   56.2%   +3.9%     
=======================================
  Files         38      39      +1     
  Lines       4967    5461    +494     
=======================================
+ Hits        2598    3074    +476     
- Misses      2369    2387     +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb merged commit 8b10ca3 into open-telemetry:main Aug 29, 2024
8 of 9 checks passed
@fiadliel fiadliel deleted the cloud_run_job branch August 30, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support Cloud Run Job monitored resource
2 participants