Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faas.max_memory should be an int and converted to Bytes #135

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Dec 9, 2024

Fixes #

As per the official docs:

The amount of memory available to the serverless function converted to Bytes.

Also, the value should be an int, not a string:

image

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@garysassano garysassano requested a review from a team as a code owner December 9, 2024 22:09
@garysassano garysassano changed the title fix: memory limit should be defined in Bytes, not MB fix: memory limit should be an int and converted to Bytes Dec 9, 2024
@garysassano garysassano changed the title fix: memory limit should be an int and converted to Bytes fix: faas.max_memory should be an int and converted to Bytes Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.4%. Comparing base (7e1c53a) to head (4d80da6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #135   +/-   ##
=====================================
  Coverage   55.4%   55.4%           
=====================================
  Files         39      39           
  Lines       6098    6101    +3     
=====================================
+ Hits        3381    3384    +3     
  Misses      2717    2717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garysassano
Copy link
Contributor Author

@cijothomas Hello, why there are so many lint errors for code that I didn't even modify?

@cijothomas
Copy link
Member

@cijothomas Hello, why there are so many lint errors for code that I didn't even modify?

The main looks to be broken :(

Would you have some bandwidth to help fix them in a separate PR? If not we'll get to it in a few days.

@cijothomas
Copy link
Member

@garysassano Thanks for fixing main branch too, really appreciate your help here.
Could you resolve conflict and we can get this merged.

@cijothomas cijothomas merged commit 4f2ac34 into open-telemetry:main Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants