-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: faas.max_memory
should be an int
and converted to Bytes
#135
Conversation
dfca045
to
b654a9d
Compare
int
and converted to Bytes
int
and converted to Bytesfaas.max_memory
should be an int
and converted to Bytes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=====================================
Coverage 55.4% 55.4%
=====================================
Files 39 39
Lines 6098 6101 +3
=====================================
+ Hits 3381 3384 +3
Misses 2717 2717 ☔ View full report in Codecov by Sentry. |
@cijothomas Hello, why there are so many lint errors for code that I didn't even modify? |
The main looks to be broken :( Would you have some bandwidth to help fix them in a separate PR? If not we'll get to it in a few days. |
@garysassano Thanks for fixing main branch too, really appreciate your help here. |
Fixes #
As per the official docs:
Also, the value should be an
int
, not astring
:Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes