-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI lint errors from new stable toolchain v1.83 #136
Conversation
Thank you ❤️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=====================================
Coverage 55.4% 55.4%
=====================================
Files 39 39
Lines 6098 6098
=====================================
Hits 3381 3381
Misses 2717 2717 ☔ View full report in Codecov by Sentry. |
The deprecation warnings in the Datadog agent sampling example can't be fixed yet because the Datadog pipeline specifically expects a While the OpenTelemetry SDK is moving away from For now, we're suppressing the deprecation warnings with |
See related issue: open-telemetry/opentelemetry-rust#2370
Changes
Fixed the following lint errors:
error: use of deprecated method `opentelemetry_sdk::trace::Builder::with_config`: Config is becoming a private type. Use Builder::with_{config_name}(resource) instead. ex: Builder::with_resource(resource)
error: the following explicit lifetimes could be elided: 'a
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes