Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI lint errors from new stable toolchain v1.83 #136

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Dec 10, 2024

See related issue: open-telemetry/opentelemetry-rust#2370

Changes

Fixed the following lint errors:

error: use of deprecated method `opentelemetry_sdk::trace::Builder::with_config`: Config is becoming a private type. Use Builder::with_{config_name}(resource) instead. ex: Builder::with_resource(resource)
error: the following explicit lifetimes could be elided: 'a
error: empty line after doc comment

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@garysassano garysassano requested a review from a team as a code owner December 10, 2024 23:06
@cijothomas
Copy link
Member

Thank you ❤️

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.4%. Comparing base (0c3771a) to head (27217ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #136   +/-   ##
=====================================
  Coverage   55.4%   55.4%           
=====================================
  Files         39      39           
  Lines       6098    6098           
=====================================
  Hits        3381    3381           
  Misses      2717    2717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garysassano
Copy link
Contributor Author

The deprecation warnings in the Datadog agent sampling example can't be fixed yet because the Datadog pipeline specifically expects a trace::Config in its builder.

While the OpenTelemetry SDK is moving away from Config in favor of using TracerProvider::builder() directly, we need to keep using the deprecated Config methods until the Datadog integration is updated to accept a TracerProvider instead.

For now, we're suppressing the deprecation warnings with #[allow(deprecated)] since this is something that needs to be fixed in the Datadog integration itself.

@garysassano garysassano changed the title Fix more CI lint error from new stable toolchain v1.83 Fix CI lint errors from new stable toolchain v1.83 Dec 11, 2024
@cijothomas cijothomas merged commit 7e1c53a into open-telemetry:main Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants