Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim host-id whitespace on Linux #141

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

wathiede
Copy link
Contributor

Changes

On Linux /etc/machine-id has a newline, it's unusual to have newlines in a resource value like host.id, so this change trims the whitespace around the value.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • [N/A] Unit tests added/updated (if applicable)
  • [N/A] Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • [N/A] Changes in public API reviewed (if applicable)

@wathiede wathiede requested a review from a team as a code owner December 14, 2024 17:43
Copy link

linux-foundation-easycla bot commented Dec 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cijothomas / name: Cijo Thomas (3bdd225)
  • ✅ login: wathiede / name: Bill (5e92826)

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.1%. Comparing base (30a3f4e) to head (3bdd225).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #141   +/-   ##
=====================================
  Coverage   54.1%   54.1%           
=====================================
  Files         42      42           
  Lines       6275    6276    +1     
=====================================
+ Hits        3400    3401    +1     
  Misses      2875    2875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cijothomas cijothomas merged commit 67b30de into open-telemetry:main Dec 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants