Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include other metric types in user-events metrics exporter #30

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Include other metric types in user-events metrics exporter #30

merged 4 commits into from
Jan 31, 2024

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jan 31, 2024

No description provided.

@lzchen lzchen requested a review from a team January 31, 2024 21:39
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (65eccba) 40.4% compared to head (d522553) 43.3%.

Files Patch % Lines
...ntelemetry-user-events-metrics/src/exporter/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main     #30     +/-   ##
=======================================
+ Coverage   40.4%   43.3%   +2.9%     
=======================================
  Files         12      11      -1     
  Lines       1279    1193     -86     
=======================================
  Hits         517     517             
+ Misses       762     676     -86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit c56e309 into open-telemetry:main Jan 31, 2024
8 of 9 checks passed
@lzchen lzchen deleted the metrics branch February 1, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzchen @lalitb @cijothomas