Improve CI speed by removing duplicate run of tests #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
=====================================
Coverage 73.6% 73.6%
=====================================
Files 122 122
Lines 19529 19529
=====================================
+ Hits 14388 14391 +3
+ Misses 5141 5138 -3 ☔ View full report in Codecov by Sentry. |
TommyCpp
reviewed
May 24, 2024
|
Looks fine. Manually checked same tests/docs tests are run! in 3min 44 secs as opposed to 5 mins. Windows ones shaved off 2 minutes and this should make CI's finish much quicker. |
TommyCpp
approved these changes
May 24, 2024
cijothomas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously running same tests multiple times. This modifies test script to run test just once, and without single thread restriction. None of the existing tests require that restriction, so we can benefit from parallelism.
Manually checked same tests/docs tests are run! in 3min 44 secs as opposed to 5 mins. Windows ones shaved off 2 minutes and this should make CI's finish much quicker.
The global tracerprovider tests were not running for a while, and this won't fix them either. See tracking issue : #1823