Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics API] Remove unnecessary auto trait implementations #2215

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Oct 16, 2024

Changes

  • Remove unnecessary Ord and PartialOrd implementation for KeyValue
  • This was only used for sorting a vec of KeyValue pairs in the SDK which could be done using sort_unstable_by method anyway

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team as a code owner October 16, 2024 00:15
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.2%. Comparing base (20f1204) to head (eec1be0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2215     +/-   ##
=======================================
- Coverage   79.2%   79.2%   -0.1%     
=======================================
  Files        122     122             
  Lines      21009   20986     -23     
=======================================
- Hits       16646   16623     -23     
  Misses      4363    4363             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changelog

@cijothomas cijothomas merged commit e6965bd into open-telemetry:main Oct 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants