example: add temporality selector option to metrics-basic #2217
Conversation
Used the full path so it can just be uncommented without needing to adjust imports
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
=====================================
Coverage 79.2% 79.2%
=====================================
Files 122 122
Lines 21009 21009
=====================================
Hits 16646 16646
Misses 4363 4363 ☔ View full report in Codecov by Sentry. |
examples/metrics-basic/src/main.rs
Outdated
| let exporter = opentelemetry_stdout::MetricsExporterBuilder::default().build(); | ||
| let exporter = opentelemetry_stdout::MetricsExporterBuilder::default() | ||
| // Build exporter using Default (Cumulative) Temporality Selector. | ||
| .with_temporality_selector( |
There was a problem hiding this comment.
@utpilla suggested this can be further simplified. An enum should be better here, delta/cumulative/lowmemory being the enum variants.
@pitoniak32 Do you have bandwidth to help make this change? Hoping to make it done by next release, so as to avoid breaking users after that release.
There was a problem hiding this comment.
Yeah for sure, I can take a look tomorrow morning. When would the next release be? Also, Is there an open issue for this currently?
There was a problem hiding this comment.
Next release is ~Oct 22-25.
No issue with all the details, #2099 is the closest. Hope that is good enough to get started.
There was a problem hiding this comment.
I took a first go at this before work this morning. I will take another look and try and clean things up later today.
Follow up PR from this comment: #2204 (review)
Changes
Add Temporality selector option to metrics-basic example
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes