-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: metrics sharding handwritten #2304
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2304 +/- ##
=====================================
Coverage 79.5% 79.6%
=====================================
Files 123 124 +1
Lines 21293 21384 +91
=====================================
+ Hits 16938 17023 +85
- Misses 4355 4361 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I did some latency testing using #2323.
|
Closing. This is linked to from the tracking issue to revisit later: #2450 |
As we discussed in our meeting, I'm creating a draft version with implemented sharding:
It mainly consist of these steps:
collect_and_reset
rustc-hash
as hashing function (seam to be faster thenahash
crate, on my machine)dashmap
.Could probably be using
dashmap
directly as well, but it's quite trivial to write it our own, and we can avoid having extra dependency :)Waiting for your test results :)
Would be good to know CPU and rust version.