Skip to content

Commit

Permalink
Formalize the overflow and cardinality limit interaction (#3912)
Browse files Browse the repository at this point in the history
  • Loading branch information
reyang authored Mar 1, 2024
1 parent 7eea730 commit 64f2340
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ release.

- Remove implementation specific specification from metric API.
([#3890](https://github.com/open-telemetry/opentelemetry-specification/pull/3890))
- Formalize the interaction between cardinality limit and overflow attribute.
([#3912](https://github.com/open-telemetry/opentelemetry-specification/pull/3912))

### Logs

Expand Down
6 changes: 3 additions & 3 deletions specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -759,9 +759,9 @@ independently aggregated because of the limit.

The SDK MUST create an Aggregator with the overflow attribute set
prior to reaching the cardinality limit and use it to aggregate events
for which the correct Aggregator could not be created. The maximum
number of distinct, non-overflow attributes is one less than the
limit, as a result.
for which the correct Aggregator could not be created. The SDK MUST provide the
guarantee that overflow would not happen if the maximum number of distinct,
non-overflow attribute sets is less than or equal to the limit.

#### Synchronous instrument cardinality limits

Expand Down

0 comments on commit 64f2340

Please sign in to comment.