Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post on Go Compile-Time Instrumentation SIG #5956

Merged
merged 19 commits into from
Jan 24, 2025
Merged

Add blog post on Go Compile-Time Instrumentation SIG #5956

merged 19 commits into from
Jan 24, 2025
+135 −0

Conversation

danielgblanco
Copy link
Contributor

@danielgblanco danielgblanco commented Jan 16, 2025 •
edited by chalin
Loading

Add blogpost after open-telemetry/community#2490 was merged and the SIG has been created, announcing donations proposals and creation of new SIG.

cc @open-telemetry/governance-committee @open-telemetry/go-compile-instrumentation-approvers

Preview: https://deploy-preview-5956--opentelemetry.netlify.app/blog/2025/go-compile-time-instrumentation/

@danielgblanco danielgblanco requested a review from a team as a code owner January 16, 2025 23:48
@opentelemetrybot opentelemetrybot requested a review from a team January 16, 2025 23:48
@github-actions github-actions bot added the blog label Jan 16, 2025
@mx-psi mx-psi requested a review from felixge January 17, 2025 09:22
RomainMuller
RomainMuller reviewed Jan 17, 2025
View reviewed changes
Copy link

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me (in the sense I have no further comments than those which were already made)

@mx-psi mx-psi self-requested a review January 17, 2025 09:37
@danielgblanco
Copy link
Contributor Author

@open-telemetry/docs-approvers can we wait until Monday to merge it, so that folks from the new SIG have time to review?

@svrnm
Copy link
Member

svrnm commented Jan 20, 2025

@open-telemetry/docs-approvers can we wait until Monday to merge it, so that folks from the new SIG have time to review?

sure! @danielgblanco just tell me when to merge and it will happen :D

@opentelemetrybot opentelemetrybot requested a review from a team January 20, 2025 09:15
@pdelewski
Copy link
Member

@danielgblanco Thank you for writing this blog post. This aligns with something I had planned to do based on the action points defined during our first SIG meeting. It looks great. One last thing from my side. I would like to include the company name in the title.

chalin
chalin requested changes Jan 20, 2025
View reviewed changes
static/refcache.json Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team January 20, 2025 16:40
@opentelemetrybot opentelemetrybot requested a review from a team January 20, 2025 16:52
chalin
chalin reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyedits, see inline.

content/en/blog/2025/go-compile-time-instrumentation.md Outdated Show resolved Hide resolved
content/en/blog/2025/go-compile-time-instrumentation.md Outdated Show resolved Hide resolved
content/en/blog/2025/go-compile-time-instrumentation.md Outdated Show resolved Hide resolved
content/en/blog/2025/go-compile-time-instrumentation.md Outdated Show resolved Hide resolved
content/en/blog/2025/go-compile-time-instrumentation.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team January 20, 2025 17:44
chalin
chalin approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @svrnm et al. for final approval, but LGTM overall. Thanks for addressing the comments @danielgblanco.

@chalin
Copy link
Contributor

chalin commented Jan 20, 2025

@danielgblanco - please rebase over main at HEAD. There are conflicts atm.

@opentelemetrybot opentelemetrybot requested a review from a team January 20, 2025 22:18
@opentelemetrybot opentelemetrybot requested a review from a team January 21, 2025 09:20
@pdelewski
Copy link
Member

pdelewski commented Jan 23, 2025 •
edited
Loading

Are there any blockers to merge this PR? cc @open-telemetry/docs-maintainers

@svrnm
Copy link
Member

svrnm commented Jan 23, 2025

Are there any blockers to merge this PR? cc @open-telemetry/docs-maintainers

No, we just want to space blog posts and we had one yesterday so we can publish this one tomorrow

@svrnm svrnm enabled auto-merge January 24, 2025 06:45
@opentelemetrybot opentelemetrybot requested a review from a team January 24, 2025 06:45
@svrnm svrnm added this pull request to the merge queue Jan 24, 2025
Merged via the queue into open-telemetry:main with commit 42cacda Jan 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y1yang0 y1yang0 y1yang0 left review comments

@chalin chalin chalin approved these changes

@jakozaur jakozaur jakozaur left review comments

@RomainMuller RomainMuller RomainMuller left review comments

@jpkrohling jpkrohling jpkrohling approved these changes

@pdelewski pdelewski pdelewski approved these changes

@123liuziming 123liuziming 123liuziming approved these changes

@mx-psi mx-psi mx-psi approved these changes

@ralf0131 ralf0131 ralf0131 approved these changes

@svrnm svrnm svrnm approved these changes

@felixge felixge Awaiting requested review from felixge

Assignees
No one assigned
Labels
blog
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.