-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post on Go Compile-Time Instrumentation SIG #5956
Open
danielgblanco
wants to merge
8
commits into
open-telemetry:main
Choose a base branch
from
danielgblanco:go_compile_time
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+140
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123liuziming
approved these changes
Jan 17, 2025
y1yang0
reviewed
Jan 17, 2025
ralf0131
reviewed
Jan 17, 2025
jpkrohling
approved these changes
Jan 17, 2025
pdelewski
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me (in the sense I have no further comments than those which were already made)
ralf0131
approved these changes
Jan 17, 2025
@open-telemetry/docs-approvers can we wait until Monday to merge it, so that folks from the new SIG have time to review? |
pdelewski
reviewed
Jan 17, 2025
pdelewski
reviewed
Jan 17, 2025
Co-authored-by: Przemyslaw Delewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add blogpost after open-telemetry/community#2490 was merged and the SIG has been created, announcing donations proposals and creation of new SIG.
cc @open-telemetry/governance-committee @open-telemetry/go-compile-instrumentation-approvers