Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources doc for .NET #1795

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Oct 2, 2022

Contributes to #1773

Similar to the JS one, but with some notable changes:

  • No process detection section (can add later if there's a good way to do it)
  • Code sample is different, as there is no semantic attributes package for .NET yet
  • Elided adding docker resources, but could add later if there's a package for that

@cartermp cartermp requested review from a team October 2, 2022 14:00
pellared
pellared previously approved these changes Oct 3, 2022
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment regarding more options on how to set service.name as it is the only required resource attribute.

@svrnm
Copy link
Member

svrnm commented Oct 4, 2022

Elided adding docker resources, but could add later if there's a package for that

@swetharavichandrancisco created an extension for that: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Extensions.Docker -- does it have all we need?

@cartermp
Copy link
Contributor Author

cartermp commented Oct 8, 2022

@pellared @cijothomas PTAL! Should be all addressed.

@svrnm
Copy link
Member

svrnm commented Oct 10, 2022

@cartermp, thoughts on adding a section for docker container id with https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Extensions.Docker ? We can do this as a follow up.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@svrnm svrnm merged commit 38df1ca into open-telemetry:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants