Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddService to .NET resource doc #1843

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

cartermp
Copy link
Contributor

First part of #1835

As noted in the issue, I can't actually get the docker resource detector to work for the simple console app.

@cartermp cartermp requested review from a team October 10, 2022 22:29
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svrnm svrnm merged commit ff9efcc into open-telemetry:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants