Remove use of service.name in example & Add info about OTEL_SERVICE_NAME #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
reviewed
Jul 12, 2023
pichlermarc
reviewed
Jul 14, 2023
pichlermarc
approved these changes
Jul 14, 2023
Yeah, that might be worthwhile as it is not 100% obvious from that page, although there is a call out at the top that this assumes that people followed the getting started |
svrnm
reviewed
Jul 14, 2023
| @@ -66,11 +66,13 @@ In the above example, the SDK detected the process and also added the | |||
| Below you will find instructions to get resources detected automatically for | |||
| you. However, you might run into the situation that no detector exists for the | |||
| resource you need. In that case you can use the environment | |||
| `OTEL_RESOURCE_ATTRIBUTES` to inject whatever you need. For example the | |||
| following script adds [Service][], [Host][] and [OS][] resource attributes: | |||
| `OTEL_RESOURCE_ATTRIBUTES` to inject whatever you need. You can use the | |||
There was a problem hiding this comment.
Suggested change
| `OTEL_RESOURCE_ATTRIBUTES` to inject whatever you need. You can use the | |
| `OTEL_RESOURCE_ATTRIBUTES` to inject whatever you need. Additionally you can use the |
minor suggestion otherwise LGTM!
There was a problem hiding this comment.
There should be a comma after "Additionally".
chalin
reviewed
Jul 14, 2023
| @@ -66,11 +66,13 @@ In the above example, the SDK detected the process and also added the | |||
| Below you will find instructions to get resources detected automatically for | |||
| you. However, you might run into the situation that no detector exists for the | |||
| resource you need. In that case you can use the environment | |||
| `OTEL_RESOURCE_ATTRIBUTES` to inject whatever you need. For example the | |||
| following script adds [Service][], [Host][] and [OS][] resource attributes: | |||
| `OTEL_RESOURCE_ATTRIBUTES` to inject whatever you need. You can use the | |||
There was a problem hiding this comment.
There should be a comma after "Additionally".
| @@ -66,11 +66,13 @@ In the above example, the SDK detected the process and also added the | |||
| Below you will find instructions to get resources detected automatically for | |||
| you. However, you might run into the situation that no detector exists for the | |||
| resource you need. In that case you can use the environment | |||
There was a problem hiding this comment.
Suggested change
| resource you need. In that case you can use the environment | |
| resource you need. In that case, use the environment variable |
| following script adds [Service][], [Host][] and [OS][] resource attributes: | ||
| `OTEL_RESOURCE_ATTRIBUTES` to inject whatever you need. You can use the | ||
| environment variable `OTEL_SERVICE_NAME` to set value of the `service.name` | ||
| resource attribute. For example the following script adds [Service][], [Host][] |
There was a problem hiding this comment.
Suggested change
| resource attribute. For example the following script adds [Service][], [Host][] | |
| resource attribute. For example, the following script adds [Service][], [Host][] |
chalin
approved these changes
Jul 14, 2023
martinkuba
approved these changes
Jul 14, 2023
cartermp
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
This change removes use of service.name in example and adds some information about setting
service.nameresource attribute via the environment variableOTEL_SERVICE_NAMEin the resources.md file of JS docs.Why the change?
This change contributes to #1830