-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python benchmarks page #3754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/Chart.min.js"></script> | ||
<script src="https://open-telemetry.github.io/opentelemetry-python/benchmarks/data.js"></script> | ||
<script id="main-script"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the other benchmark files, but is the JS here the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any updates on this one? |
Working on this... |
I tried to fix the failing test by running
I got this error:
|
@ocelotl what version of Node.JS are you using? Can you remove |
Looking now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this wrapper code is identical to the JS wrapper code, which doesn't have layout issues. The only difference is in the imported JavaScript. I suspect that the python benchmark code that's been imported does something weird here. |
Yes, @ocelotl spend a lot of time in this already and I would prefer seeing this PR closed. Also those issues are not 100% unique to python, I can also get the JS/Collector pages to break if I choose my window dimension in a certain way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's move ahead with this. Thanks all!
We'll tackle the identified issues separately.
Yeah, I suspect there's some wrapper code we could write that takes care of this |
Fixes #3683
Preview: https://deploy-preview-3754--opentelemetry.netlify.app/docs/languages/python/benchmarks/