-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET manual instrumentation docs with example app #3834
Conversation
|
thanks for kicking this off @IAMebonyhope ! Here's the preview: https://deploy-preview-3834--opentelemetry.netlify.app/docs/languages/net/instrumentation/ cc @open-telemetry/docs-approvers , @open-telemetry/dotnet-approvers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some language and formatting suggestions.
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's definitely looking good @IAMebonyhope! Added some comments, feel free to tag me if you have more!
@IAMebonyhope anything you need to move this forward? |
@svrnm I'll work on resolving the comments this week |
Pushed a new iteration and responded to comments @svrnm @cijothomas @reyang please can you take another look? |
Signed-off-by: svrnm <[email protected]>
//... | ||
|
||
// Register the ActivitySource as a singleton in the DI container. | ||
// Create a service to expose the ActivitySource Instruments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Create a service to expose the ActivitySource Instruments. | |
// Create a service to expose the ActivitySource. |
Unless you plan to add metric instruments as well to Instrumentation.cs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed that line and updated the above comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Left some more comments, but okay to address them as follow ups.
Co-authored-by: Cijo Thomas <[email protected]>
Signed-off-by: svrnm <[email protected]>
Thanks @IAMebonyhope for all the effort put into this! I merged the PR and this should be live in a minute. I will also create a few follow up issues on the remaining non-blocking feedback |
This is to solve the .Net aspect of this issue #3229
Completed the Example App, Setup and Traces section.
I can add metrics and logs in another PR.