Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document configuration options for java agent enduser attribute collection #3982

Merged

Conversation

jaydeluca
Copy link
Member

@trask
Copy link
Member

trask commented Feb 12, 2024

maybe a note about which libraries produce these attributes when enabled?

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

content/en/docs/languages/java/automatic/configuration.md Outdated Show resolved Hide resolved
content/en/docs/languages/java/automatic/configuration.md Outdated Show resolved Hide resolved
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jaydeluca jaydeluca marked this pull request as ready for review February 15, 2024 21:34
@jaydeluca jaydeluca requested review from a team February 15, 2024 21:34
@svrnm svrnm requested a review from theletterf February 16, 2024 11:26
@svrnm
Copy link
Member

svrnm commented Feb 16, 2024

lgtm, @theletterf can you take another look?

@svrnm svrnm added the sig:java label Feb 16, 2024
@cartermp cartermp merged commit 6652bd0 into open-telemetry:main Feb 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants