[Erlang] RollDice-related doc improvements #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apreifsteck Hi there! Could you please sign the CLA and add a bit of context in the description? Thanks! |
apreifsteck
force-pushed
the
getting_started_documentation_update
branch
from
c75672c to
1f2d834
Compare
apreifsteck
force-pushed
the
getting_started_documentation_update
branch
from
b80d1ac to
4347eea
Compare
chalin
force-pushed
the
getting_started_documentation_update
branch
from
4347eea to
117ba21
Compare
chalin
changed the title
chalin
force-pushed
the
getting_started_documentation_update
branch
from
117ba21 to
0a6a61f
Compare
|
Thanks for this @apreifsteck. I'll let @open-telemetry/erlang-approvers comment about the content. Note that a few of the GitHub checks are failing. You'll need to pull this PR branch back down, rebase from |
tsloughter
reviewed
Jun 8, 2024
| @@ -17,12 +17,18 @@ Add the following dependencies to your project: | |||
| - `opentelemetry`: contains the SDK that implements the interfaces defined in | |||
| the API. Without it, all the functions in the API are no-ops. | |||
|
|
|||
| Optionally, you may choose to include the `open_telemetry_decorator` library. | |||
| Note that this library is not officially supported by the opentelemetry project, | |||
There was a problem hiding this comment.
This should be removed since not officially supported.
|
Changes look ok and are important (module names are wrong currently) but one thing should be removed that I noted. |
apreifsteck
force-pushed
the
getting_started_documentation_update
branch
from
1514190 to
bea0f17
Compare
svrnm
approved these changes
Jun 10, 2024
tsloughter
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light edits to the documentation to streamline the getting started guide, and adds some tips and gotchas.
More details:
RollDiceinstead ofDiceGame(DiceGame outdated)