Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Add language codes #4622

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 7, 2024

  • Contributes to Improved i18n support #4467
  • Adds language codes specifying what the implicit specific localization is. This affects the <html lang> attribute.

@chalin chalin added the i18n internationalization label Jun 7, 2024
@chalin chalin requested a review from a team June 7, 2024 13:58
@@ -21,6 +22,7 @@ languages:
description: OpenTelemetryプロジェクト公式サイト
zh:
languageName: 中文 (Chinese)
languageCode: zh-cn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/docs-zh-approvers - is this ok with you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chalin chalin merged commit a71aca9 into open-telemetry:main Jun 7, 2024
16 checks passed
@chalin chalin deleted the chalin-im-i18n-lang-codes-2024-06-07 branch June 7, 2024 14:43
@chalin chalin mentioned this pull request Jun 7, 2024
41 tasks
ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants