Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI & ja & zh] Enable format check, and fixes for ja and zh #4631

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 8, 2024

@chalin chalin added CI/infra CI & infrastructure i18n internationalization labels Jun 8, 2024
@chalin chalin requested review from ymotongpoo and a team June 8, 2024 00:24
@chalin chalin changed the title [ja & zh] Enable format check and fix for ja and zh [CI & ja & zh] Enable format check and fix for ja and zh Jun 8, 2024
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin the change just includes format changes and no affections to the translations. LGTM.

@chalin chalin force-pushed the chalin-im-prettier-ja-2024-06-07 branch from bc6458e to 677a32b Compare June 8, 2024 12:21
@chalin chalin changed the title [CI & ja & zh] Enable format check and fix for ja and zh [CI & ja & zh] Enable format check, and fixes for ja and zh Jun 8, 2024
@chalin chalin force-pushed the chalin-im-prettier-ja-2024-06-07 branch from 677a32b to 53f33d8 Compare June 8, 2024 19:11
@chalin
Copy link
Contributor Author

chalin commented Jun 8, 2024

@open-telemetry/docs-zh-approvers - since the zh change is table column spacing adjustment only, I'm going to assume that it's ok with you. If not, let me know and we'll adjust in a followup PR.

@chalin chalin merged commit c2cd5b1 into open-telemetry:main Jun 8, 2024
16 checks passed
@chalin chalin deleted the chalin-im-prettier-ja-2024-06-07 branch June 8, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n internationalization lang:ja lang:zh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI & i18n] Support page formatting for ja and zh pages
3 participants