Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in config_option shortcode #4709

Closed
wants to merge 1 commit into from
Closed

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 18, 2024

This addresses #4230. Note that this PR is not yet finalized, but to begin with it demonstrates the underlying issue.

There seems to be an issue with hugo "re-markdownifying" (see gohugoio/hugo#5774 (comment)), so this applies the same suggestions:

  1. Use {{< request >}} instead of {{% request %}}, so Hugo stops trying to re-markdownify
  2. Manually markdownify the content

cc @chalin

@chalin chalin added this to the 24Q3 milestone Jul 4, 2024
@chalin chalin removed the sig:java label Jul 4, 2024
@chalin
Copy link
Contributor

chalin commented Jul 4, 2024

Thanks, I appreciate the time you put into investigating this. I can't recall the reason why I made the shortcode an HTML file (other than it mainly contains only HTML :)). What you've implemented here feels like a workaround. I'd like to try to fix the source of the problem. The first thing that I'd try is to rename the shortcode to config_option.md and try to get it to work from there. I don't know when I'll have the time to do that.

Have you double checked that this "fix" doesn't break other invocations of config_option?

@svrnm
Copy link
Member Author

svrnm commented Jul 11, 2024

Thanks, I appreciate the time you put into investigating this. I can't recall the reason why I made the shortcode an HTML file (other than it mainly contains only HTML :)). What you've implemented here feels like a workaround. I'd like to try to fix the source of the problem. The first thing that I'd try is to rename the shortcode to config_option.md and try to get it to work from there. I don't know when I'll have the time to do that.

That would be great!

Have you double checked that this "fix" doesn't break other invocations of config_option?

No, I haven't, that's why this is a draft PR, I didn't want to add this without further investigation from your site.

@svrnm
Copy link
Member Author

svrnm commented Aug 1, 2024

@chalin I will close this PR now, since it only was a proof of concept, it's linked to the original issue

@svrnm svrnm closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants