-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel Docs Localized Announcement Blog Post #4996
Conversation
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass with vacation brain! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments, mainly on the announcement :)
Awesome announcement! Just asking a question on behalf of @open-telemetry/docs-ja-approvers: can this announcement be localized? Maybe @chalin should know the eligibility the best? |
Co-authored-by: Patrice Chalin <[email protected]> Co-authored-by: Tiffany Hrabusa <[email protected]>
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10315257993 |
@tiffany76 @chalin thanks for your review @ymotongpoo having this blog post multilingual would be great! @chalin wdyt, what's the best way to incorporate that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good to see this :)
Add a translation of the announcement just like for any other page. |
Co-authored-by: Patrice Chalin <[email protected]>
Signed-off-by: svrnm <[email protected]>
I applied all suggestions by @chalin in the last commit |
Addresses #4863
cc @open-telemetry/docs-ja-approvers @open-telemetry/docs-cn-approvers @open-telemetry/docs-approvers @open-telemetry/governance-committee