Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel Docs Localized Announcement Blog Post #4996

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Aug 8, 2024

Addresses #4863

cc @open-telemetry/docs-ja-approvers @open-telemetry/docs-cn-approvers @open-telemetry/docs-approvers @open-telemetry/governance-committee

@svrnm svrnm requested a review from a team August 8, 2024 14:07
@opentelemetrybot opentelemetrybot requested a review from a team August 8, 2024 14:08
@github-actions github-actions bot added the blog label Aug 8, 2024
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass with vacation brain! 😃

content/en/announcements/otel-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments, mainly on the announcement :)

content/en/announcements/otel-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/announcements/otel-localized.md Outdated Show resolved Hide resolved
content/en/announcements/otel-localized.md Outdated Show resolved Hide resolved
@ymotongpoo
Copy link
Contributor

Awesome announcement! Just asking a question on behalf of @open-telemetry/docs-ja-approvers: can this announcement be localized? Maybe @chalin should know the eligibility the best?

Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
@opentelemetrybot opentelemetrybot requested a review from a team August 9, 2024 07:14
@svrnm
Copy link
Member Author

svrnm commented Aug 9, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10315257993

@svrnm
Copy link
Member Author

svrnm commented Aug 9, 2024

@tiffany76 @chalin thanks for your review

@ymotongpoo having this blog post multilingual would be great! @chalin wdyt, what's the best way to incorporate that?

content/en/announcements/otel-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
Copy link
Contributor

@danielgblanco danielgblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good to see this :)

@opentelemetrybot opentelemetrybot requested a review from a team August 9, 2024 09:49
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Aug 9, 2024

@ymotongpoo having this blog post multilingual would be great! @chalin wdyt, what's the best way to incorporate that?

Add a translation of the announcement just like for any other page.

@opentelemetrybot opentelemetrybot requested a review from a team August 9, 2024 17:29
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/en/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Aug 9, 2024

FYI:

@opentelemetrybot opentelemetrybot requested a review from a team August 13, 2024 13:50
@svrnm
Copy link
Member Author

svrnm commented Aug 13, 2024

I applied all suggestions by @chalin in the last commit

@svrnm svrnm added this pull request to the merge queue Aug 19, 2024
Merged via the queue into open-telemetry:main with commit 30f5960 Aug 19, 2024
17 checks passed
@svrnm svrnm deleted the otel-localized branch August 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants