Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mount points for es pages #5005

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Add mount points for es pages #5005

merged 3 commits into from
Aug 9, 2024

Conversation

theletterf
Copy link
Member

@theletterf theletterf commented Aug 9, 2024 •
edited
Loading

Follow up of #4989

+CC @chalin

@theletterf theletterf requested a review from a team August 9, 2024 09:28
@theletterf theletterf self-assigned this Aug 9, 2024
chalin
chalin reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the fallback pages too.

@theletterf
Copy link
Member Author

@chalin Added — thanks!

@theletterf theletterf requested a review from chalin August 9, 2024 09:40
@chalin chalin added this pull request to the merge queue Aug 9, 2024
@chalin chalin mentioned this pull request Aug 9, 2024
Closed
13 tasks
Merged via the queue into main with commit 3412946 Aug 9, 2024
19 checks passed
@chalin chalin deleted the add-es-mount-point branch August 9, 2024 11:29
@chalin chalin mentioned this pull request Aug 9, 2024
Closed
4 tasks
@chalin
Copy link
Contributor

chalin commented Aug 9, 2024

Follow up (FYI):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@svrnm svrnm svrnm approved these changes

Assignees

@theletterf theletterf

Labels
lang:es
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theletterf @chalin @svrnm