Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intro to OpenTelemetry Java page #5471

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Oct 24, 2024

Part of #5211.

Add new "Intro to OpenTelemetry Java" page, introducing key aspects of the OpenTelemetry Java ecosystem and establishing basic vocabulary to help route users to the right pages for additional details.

Preview available here: https://deploy-preview-5471--opentelemetry.netlify.app/docs/languages/java/intro/

@jack-berg jack-berg requested a review from a team as a code owner October 24, 2024 01:40
@opentelemetrybot opentelemetrybot requested review from a team October 24, 2024 01:40
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I broke this content out to a page but it could just as easily live in _index.md. The advantage of a dedicated page is that its easier to find in the nav. It might not always be intuitive that "Java" is itself a page, instead of just a button to expand / contract children.

Screenshot 2024-10-23 at 8 41 21 PM

Click the link in the "Managed Dependencies" column to see a list of the
artifacts managed by the BOM.

| Description | Repository | Group ID | Artifact ID | Current Version | Managed Dependencies |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Managed Dependencies" column of this table is awesome. It links to the current version of each BOM's pom.xml, allowing the user to see the list of managed dependencies at a glance, guaranteed to be up to date.

different use cases, listed below in order of increasing scope. We highly
recommend using a BOM. Because the BOMs are hierarchical, adding dependencies on
multiple BOMs is not recommended, as it is redundant and can lead unintuitive
dependency version resolution.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding dependencies on multiple BOMs is not recommended

This is a new an important piece of advice. Choose your BOM wisely!

@@ -14,74 +14,3 @@ weight: 18
---

{{% docs/languages/index-intro java /%}}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this content moves to intro.md.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me overall! thanks once again

content/en/docs/languages/java/intro.md Outdated Show resolved Hide resolved
content/en/docs/languages/java/intro.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team October 24, 2024 14:24
@jack-berg
Copy link
Member Author

Ping @open-telemetry/docs-maintainers. I think this is good to merge.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work here.

@cartermp cartermp added this pull request to the merge queue Nov 2, 2024
Merged via the queue into open-telemetry:main with commit 1cfbf5b Nov 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants