-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix version update script #5758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeitlinger, thanks for surfacing the issue and proposing a fix! 🙌🏻
I've created the following issue to track discussion about the source of the problem and followup fixes (like this PR -- we'll likely need to do more):
Regarding the build failures that we can see from https://github.com/open-telemetry/opentelemetry.io/actions/runs/12278556636/job/34260597540?pr=5758:
Run scripts/check-build-log.sh
WARNINGs or ERRORs found in build log:
ERROR Param "vers.collector" not found: "/home/runner/work/opentelemetry.io/opentelemetry.io/content/en/docs/collector/installation.md:19:10"
ERROR Param "vers.collector" not found: "/home/runner/work/opentelemetry.io/opentelemetry.io/content/en/docs/collector/installation.md:81:92"
ERROR Param "vers.collector" not found: "/home/runner/work/opentelemetry.io/opentelemetry.io/content/en/docs/collector/installation.md:1:1"
Error: error building site: logged 3 error(s)
This is actually due (I think) to:
Let me investigate further and get back to you.
Actually, it's not even because of #5761. I'm stumped as to why those errors are being reported. The same font-matter params work in another section, but not under the Collector section. I'll continue to investigate as soon as I can, and will keep y'all posted. Converting to draft in the meantime. |
@zeitlinger - as I mention in #5769, which I proposed as an alternative to this PR, I just can't figure our the source of the failures in this PR. There's no reason for the cascaded fields not to be picked up. I'd have to try to create a small test case, which I don't have time for atm. PTAL #5769 and let me/us know if this works for you. |
The version script expects version updates to be grouped - which they were not
Here's run where a PR has updated only one of the files - and the second results it this:
https://github.com/open-telemetry/opentelemetry.io/actions/runs/12276199179/job/34252893445