Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates to the java agent zero code docs #5857

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Small updates to the java agent zero code docs #5857

merged 1 commit into from
Dec 30, 2024

Conversation

jaydeluca
Copy link
Member

  • Some small changes to the wording of some sections so they flow a little better
  • Added emphasis on the note around the complexity of disabling instrumentation, as discussed in a recent SIG meeting
  • Moved some gradle/maven code into a tab pane

One other thing I tried to fix was the rendering of this section, particularly this line which doesn't seem to be rendering properly:

image

I wasn't able to figure out a fix, in case anyone has any tips on how I can address that

@jaydeluca jaydeluca requested a review from a team as a code owner December 29, 2024 22:56
@opentelemetrybot opentelemetrybot requested review from a team December 29, 2024 22:57
cartermp
cartermp approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is good to take as-is, since it doesn't introduce formatting issues that weren't already there.

@cartermp cartermp added this pull request to the merge queue Dec 30, 2024
Merged via the queue into open-telemetry:main with commit 4dda37f Dec 30, 2024
17 checks passed
ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jan 2, 2025
@jaydeluca @ymotongpoo
Small updates to the java agent zero code docs (open-telemetry#5857)
ea08962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
blog sig:java
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaydeluca @cartermp