Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fixes to github.com links for opentelemetry-dotnet-instrumentation and more #5973

7 changes: 6 additions & 1 deletion .htmltest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,15 @@ IgnoreURLs: # list of regexs of paths or URLs to be ignored
# Ignore Docsy-generated GitHub links for now, until
# https://github.com/google/docsy/issues/1432 is fixed
- ^https?://github\.com/.*?/.*?/(new|edit|issues/new\?title)/ # view-page, edit-source etc
# Here's an approximate regex to avoid the "View page source" links. TODO: fix this in Docsy
- ^https?://github\.com/open-telemetry/opentelemetry.io/tree/
# FIXME: A patch until we can get Docsy to mark "View page source" links as excluded from link checking,
# Actually, it would be better to pin the version of the OTel spec.
- ^https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/logs/event-(api|sdk)\.md
# FIXME: same issue as for the OTel spec mentioned above:
- ^https://github.com/open-telemetry/semantic-conventions/tree/main

# Ignore some links to GH repo content for now, most 4XX
- ^https?://github\.com/open-telemetry/(opentelemetry-dotnet-instrumentation|opentelemetry-helm-charts|opentelemetry-java-instrumentation|opentelemetry-java|opentelemetry-operator|opentelemetry-proto|opentelemetry-python-contrib|opentelemetry-specification|oteps|semantic-conventions|sig-end-user)/
- ^https?://github\.com/open-telemetry/opentelemetry-demo/blob/main/src/(imageprovider|loadgenerator|otelcollector|.*service)
# TODO drop the following after https://github.com/open-telemetry/semantic-conventions/pull/1753 is merged and the submodule updated:
- ^https?://github\.com/in-toto/
Expand Down
2 changes: 1 addition & 1 deletion content/en/blog/2024/otel-generative-ai/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ opentelemetry-instrument --traces_exporter console --metrics_exporter console py
```

There is a complete example
[available here](https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation-genai/opentelemetry-instrumentation-openai-v2/example).
[available here](https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link fix, cc @lmolkova @drewby


With this simple instrumentation, one can begin capture traces from their
generative AI application. Here is an example from the
Expand Down
2 changes: 1 addition & 1 deletion content/en/docs/zero-code/net/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ CI tests run against the following operating systems:
- [Alpine ARM64](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docker/alpine.dockerfile)
- [Debian x64](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docker/debian.dockerfile)
- [Debian ARM64](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docker/debian-arm64.dockerfile)
- [CentOS 7 x64](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docker/centos-build.dockerfile)
- [CentOS 7 x64](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/v1.9.0/docker/centos-build.dockerfile)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/dotnet-approvers - can you comment on this update. Maybe rather than pinning down to v1.9.0, you would have preferred that I use https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docker/centos-stream9.dockerfile?

(.NET 8 is not supported)
- [macOS Monterey 12 x64](https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md)
- [Microsoft Windows Server 2022 x64](https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md)
Expand Down
2 changes: 1 addition & 1 deletion data/registry/instrumentation-java-struts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ description: This package provides an instrumentation library for Struts
authors:
- name: OpenTelemetry Authors
urls:
repo: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/struts-2.3
repo: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/struts/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask - does this look ok to you? (AFAIR you added this entry.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this looks good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming.

createdAt: 2020-11-05
isFirstParty: false
Loading
Loading