-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semconv 1.24.0 #46
Merged
Merged
Semconv 1.24.0 #46
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
07ceccc
Upgrade to semconv 1.24.0
jack-berg 4b00396
Merge branch 'main' of https://github.com/open-telemetry/semantic-con…
jack-berg ccacbca
Merge branch 'main' of https://github.com/open-telemetry/semantic-con…
jack-berg 7dcb7e3
Exclude aspnetcore, signalr root namespaces
jack-berg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
...ncubating/src/main/java/io/opentelemetry/semconv/incubating/DiskIncubatingAttributes.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package io.opentelemetry.semconv.incubating; | ||
|
||
import static io.opentelemetry.api.common.AttributeKey.stringKey; | ||
|
||
import io.opentelemetry.api.common.AttributeKey; | ||
|
||
// DO NOT EDIT, this is an Auto-generated file from | ||
// buildscripts/templates/SemanticAttributes.java.j2 | ||
@SuppressWarnings("unused") | ||
public final class DiskIncubatingAttributes { | ||
|
||
/** The disk IO operation direction. */ | ||
public static final AttributeKey<String> DISK_IO_DIRECTION = stringKey("disk.io.direction"); | ||
|
||
// Enum definitions | ||
/** Values for {@link #DISK_IO_DIRECTION}. */ | ||
public static final class DiskIoDirectionValues { | ||
/** read. */ | ||
public static final String READ = "read"; | ||
|
||
/** write. */ | ||
public static final String WRITE = "write"; | ||
|
||
private DiskIoDirectionValues() {} | ||
} | ||
|
||
private DiskIncubatingAttributes() {} | ||
} |
32 changes: 32 additions & 0 deletions
32
...incubating/src/main/java/io/opentelemetry/semconv/incubating/DnsIncubatingAttributes.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package io.opentelemetry.semconv.incubating; | ||
|
||
import static io.opentelemetry.api.common.AttributeKey.stringKey; | ||
|
||
import io.opentelemetry.api.common.AttributeKey; | ||
|
||
// DO NOT EDIT, this is an Auto-generated file from | ||
// buildscripts/templates/SemanticAttributes.java.j2 | ||
@SuppressWarnings("unused") | ||
public final class DnsIncubatingAttributes { | ||
|
||
/** | ||
* The name being queried. | ||
* | ||
* <p>Notes: | ||
* | ||
* <ul> | ||
* <li>The name being queried. If the name field contains non-printable characters (below 32 or | ||
* above 126), those characters should be represented as escaped base 10 integers (\DDD). | ||
* Back slashes and quotes should be escaped. Tabs, carriage returns, and line feeds should | ||
* be converted to \t, \r, and \n respectively. | ||
* </ul> | ||
*/ | ||
public static final AttributeKey<String> DNS_QUESTION_NAME = stringKey("dns.question.name"); | ||
|
||
private DnsIncubatingAttributes() {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova This is an example of an experimental attribute that was deleted rather retained but marked as deprecated.
Based on what you said, in the future this will not be the case. And we would expect to keep this attribute around semi-permanently marked as deprecated. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not trying to answer for @lmolkova, and I'm not addressing the general question being asked....but in this specific case I do think it makes sense to remove it, because (experimental) Events are starting to gel and we don't want people using this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I missed it.
Yes, starting from 1.24.0 we'll have a check that prevents attributes (and metrics) from being deleted - open-telemetry/semantic-conventions#764
It would apply to experimental and stable semconv.
I think we'll need to do the same for events, updated open-telemetry/build-tools#292 so we don't forget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I guess that's fine, as long as they're marked deprecated and can be removed in the subsequent release. I'd hate for us to have constraints that cause long-term maintenance burden due to changes in experimental semconv (and yes, I realize this isn't the place to drag this out, heh 😅 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to hear your thoughts on removing-experimental-deprecated on open-telemetry/semantic-conventions#740. It'd be great to have a common policy for all language SIGs.