Skip to content

Commit

Permalink
Pr suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
joaopgrassi committed Dec 27, 2024
1 parent d537c6d commit 568f90c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions docs/messaging/rabbitmq.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,11 @@ The Semantic Conventions for [RabbitMQ](https://www.rabbitmq.com/) extend and ov

`messaging.destination.name` SHOULD be set to:

- **Producers**: `{exchange}:{routing key}` when both values are present and non-empty.
- **On the producer side**: `{exchange}:{routing key}` when both values are present and non-empty.
When only one is available, only that value SHOULD be used. E.g., `{exchange}` or `{routing key}`.
Otherwise: `amq.default` when the default exchange is used and no routing key is provided

- **Consumers**: `{exchange}:{routing key}:{queue}` when all values are present and non-empty.
- **On the consumer side**: `{exchange}:{routing key}:{queue}` when all values are present and non-empty.
If any has an empty value (e.g., the default exchange is used) it SHOULD be omitted.
For cases when `{routing key}` and `{queue}` are equal, only one of them SHOULD
be used, e.g., `{exchange}:{routing key}`.
Expand Down
5 changes: 3 additions & 2 deletions model/messaging/spans.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,11 @@ groups:
`messaging.destination.name` SHOULD be set to:
- **Producers**: `{exchange}:{routing key}` when both values are present and non-empty.
- **On the producer side**: `{exchange}:{routing key}` when both values are present and non-empty.
When only one is avaiable, only that value SHOULD be used. E.g., `{exchange}` or `{routing key}`.
Otherwise: `amq.default` when the default exchange is used and no routing key is provided
- **Consumers**: `{exchange}:{routing key}:{queue}` when all values are present and non-empty.
- **On the consumer side**: `{exchange}:{routing key}:{queue}` when all values are present and non-empty.
If any has an empty value (e.g., the default exchange is used) it SHOULD be omitted.
For cases when `{routing key}` and `{queue}` are equal, only one of them SHOULD
be used, e.g., `{exchange}:{routing key}`.
Expand Down

0 comments on commit 568f90c

Please sign in to comment.