Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move Dynamodb attributes to the registry #850

Merged

Conversation

joaopgrassi
Copy link
Member

Related to #407

Changes

Move AWS Dynamodb to the attributes registry

Merge requirement checklist

@AlexanderWert
Copy link
Member

The dynamoDB attributes namespace is inconsistent with the rest of all DBs (i.e. aws.dynamodb.* vs. db.dynamodb.*).
I'm wondering whether we should move these attributes now to the registry (and with that introduce the aws.dynamodb namespace in the registry) or wait until this resolved in the DB SemConv WG and move it then. I have no strong opinion though.

@joaopgrassi
Copy link
Member Author

I will try to work on these AWS ones this week.

@joaopgrassi
Copy link
Member Author

@AlexanderWert @trisch-me I applied the suggestions and this should be good for another review. Thanks!

Copy link
Member

@AlexanderWert AlexanderWert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopgrassi joaopgrassi merged commit 8dc38ec into open-telemetry:main Apr 3, 2024
11 checks passed
@joaopgrassi joaopgrassi deleted the move-dynamodb-registry branch April 3, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants