add parachain c #699
Open
add parachain c #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 74.63% 74.74% +0.11%
==========================================
Files 83 83
Lines 7261 7293 +32
==========================================
+ Hits 5419 5451 +32
Misses 1842 1842
Continue to review full report at Codecov.
|
shaunxw
reviewed
Feb 20, 2022
| _ => None, | ||
| }, | ||
| MultiLocation { parents, interior } if parents == 0 => match interior { | ||
| X1(GeneralKey(k)) if k == a => Some(CurrencyId::A), | ||
| X1(GeneralKey(k)) if k == b => Some(CurrencyId::B), | ||
| X1(GeneralKey(k)) if k == a1 => Some(CurrencyId::A1), | ||
| X1(GeneralKey(k)) if k == b1 => Some(CurrencyId::B1), | ||
| Here => Some(CurrencyId::C), |
There was a problem hiding this comment.
Parachains in mock shares the same CurrencyIdConvert, this will make all of them convert Here to CurrencyId::C, which doesn't make sense.
You'll need to define a convert impl only for Parachain C.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some parachain may not use
GeneralKeyas its token, but use just its parachain, i.e. PHA:https://github.com/AcalaNetwork/Acala/blob/d92b2db7e384ebf24dafc89d7cc0e04ee4724435/runtime/karura/src/lib.rs#L1811-L1812
this PR add parachain c, and use parachain(3) to represent its token.