support the latest version 2.1.1 schema changes to the server side implementation #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at00825957
requested review from
PrathibaJee,
MartinSunal,
DanaSunal,
vanithavalluripalli9 and
IswaryaaS
as code owners
IswaryaaS
requested changes
Feb 20, 2024
| @@ -25,7 +25,7 @@ var app = expressAppConfig.getApp(); | |||
| appCommons.setupExpressApp(app); | |||
|
|
|||
| //setting the path to the database | |||
| global.databasePath = './database/load.json' | |||
| global.databasePath = './database/config.json' | |||
There was a problem hiding this comment.
please update the server-port value to the one which shall be used for v2.1.0 of EATL application.
Please refer ApplicationPattern/docs/FakeIpAddress table
There was a problem hiding this comment.
Also, we can update the port in docker-file, so that it would be aligned to documentation
There was a problem hiding this comment.
Hi @IswaryaaS, I have updated it. Please check.
IswaryaaS
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support the latest version 2.1.1 schema changes to the server side implementation
Resolve issue-338