-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new implementation for multicontainer use case #67
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5a92717
support for config
AadilLatif 5ae3ae0
docker compose working
AadilLatif e2b94b0
fixed host/hostname bug
AadilLatif 79c391f
minor edits
AadilLatif 2e4948d
minimal edits to support changes to multicontainer implementation
AadilLatif 17838ba
moving system.json to scenarios folder
AadilLatif 3e6b426
example updates
AadilLatif 35d2e19
logger fix
AadilLatif de5a1a4
bug fix for broker serveer
AadilLatif deb5bd4
fixed hostname parenthesis issue
AadilLatif 92d17ae
updating requirements.txt files
AadilLatif 3ac06b6
updating docker files
AadilLatif 790ea5a
removing pip cache
AadilLatif 1173caa
Merge branch 'main' into al/config
AadilLatif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,5 @@ boto3 | |
xarray | ||
fastapi | ||
uvicorn | ||
oedisi==1.1.1 | ||
git+https://github.com/openEDI/oedisi@al/config | ||
python-multipart |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmckinsey marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
networks: | ||
custom-network: | ||
driver: bridge | ||
ipam: | ||
config: | ||
- gateway: 10.5.0.1 | ||
subnet: 10.5.0.0/16 | ||
services: | ||
oedisi_broker: | ||
build: | ||
context: ./broker/. | ||
environment: | ||
PORT: '8766' | ||
hostname: broker | ||
image: aadillatif/oedisi_broker | ||
networks: | ||
custom-network: {} | ||
ports: | ||
- 8766:8766 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ fastapi | |
uvicorn | ||
requests | ||
grequests | ||
oedisi==1.1.1 | ||
git+https://github.com/openEDI/oedisi@al/config |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to add a comment on the right section, but I noticed a couple problems caused by this function when trying to run with SMART-DS as well as deleting the existing sensors.json file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will have to resolve this issue once we have sensors published on the helics interface