Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incidence for 3-winding transformers #72

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Fix incidence for 3-winding transformers #72

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf87b46
Fix incidence for 3-winding transformers
Mar 20, 2024
bd8e344
Add incidence matrix fix for 3-winding transformer
Mar 25, 2024
ab5a1bb
Add warning when there is really a 3-winding transformer
Mar 25, 2024
d18ac8f
Remove unneeded logging
Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions LocalFeeder/FeederSimulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""Core class to abstract OpenDSS into Feeder class."""

import json
import logging
import math
Expand Down Expand Up @@ -590,9 +591,9 @@ def _get_voltages(self):
name_voltage_dict = get_voltages(self._circuit)
res_feeder_voltages = np.zeros((len(self._AllNodeNames)), dtype=np.complex_)
for voltage_name in name_voltage_dict.keys():
res_feeder_voltages[
self._name_index_dict[voltage_name]
] = name_voltage_dict[voltage_name]
res_feeder_voltages[self._name_index_dict[voltage_name]] = (
name_voltage_dict[voltage_name]
)

return xr.DataArray(
res_feeder_voltages, {"ids": list(name_voltage_dict.keys())}
Expand Down Expand Up @@ -826,14 +827,22 @@ def get_incidences(self) -> IncidenceList:
equipment_types = []
for line in dss.Lines.AllNames():
dss.Circuit.SetActiveElement("Line." + line)
from_bus, to_bus = dss.CktElement.BusNames()
names = dss.CktElement.BusNames()
if len(names) != 2:
logging.info(f"Line {line} does not have two terminals")
continue
from_bus, to_bus = names
from_list.append(from_bus.upper())
to_list.append(to_bus.upper())
equipment_ids.append(line)
equipment_types.append("Line")
for transformer in dss.Transformers.AllNames():
dss.Circuit.SetActiveElement("Transformer." + transformer)
from_bus, to_bus = dss.CktElement.BusNames()
names = dss.CktElement.BusNames()
if len(names) != 2:
logging.info(f"Transformer {transformer} does not have two terminals")
continue
from_bus, to_bus = names
from_list.append(from_bus.upper())
to_list.append(to_bus.upper())
equipment_ids.append(transformer)
Expand Down
Loading