1094 select proforma version for export direct download api

[kkoehn]

depends on openHPI/proformaxml#409

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (138864c) to head (6b829d6).
Report is 8 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1550   +/-   ##
=======================================
  Coverage   94.13%   94.14%           
=======================================
  Files         123      123           
  Lines        3000     3004    +4     
=======================================
+ Hits         2824     2828    +4     
  Misses        176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MrSerth]

Great work already! If you don't mind, here is some feedback already (besides the "draft" status of the PR). I tested the functionality with CodeOcean already and it worked flawlessly with either version 😁

[kkoehn]

@MrSerth thanks for the feedback, I fixed your suggestions. I'm still waiting to merge the proforma PR, so we can also fix those edge-cases.

[MrSerth]

Thanks for integrating my feedback already. Here's some follow-up feedback I found, but otherwise I am fine with the changes.

For sure, I'll remind @Dome-GER about the missing review for openHPI/proformaxml#409 to unblock the current PR.

[MrSerth]

Since openHPI/proformaxml#409 was merged, we can now draft a new ProFormA version, update this PR and undraft it.

[kkoehn]

@MrSerth Do you think we need to address the case of more ProformaXML version being added? Currently it is assumed that every saved task has the latest version. If a new version gets added that could lead to problems. A possible solution could be to add a proforma_version column on task. What do you think?

[MrSerth]

@MrSerth Do you think we need to address the case of more ProformaXML version being added?

Not necessarily. The ProFormA working group is currently not working on a new version, so that I don't expect major changes in the near future (there could be a bugfix release, of course).

Currently it is assumed that every saved task has the latest version. If a new version gets added that could lead to problems.

I see. I would actually keep that assumption and would ensure that all existing tasks are migrated to a newer version when we add the respective version support in the future.

A possible solution could be to add a proforma_version column on task. What do you think?

Sure, could work. However, as mentioned above, I would not do so right now.