Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict false positive warning #693

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Sep 24, 2024

"Environment stopped unexpectedly," which also got triggered by migrations.

Related to #672

@mpass99 mpass99 self-assigned this Sep 24, 2024
"Environment stopped unexpectedly" that got also triggered on migrations.
@mpass99 mpass99 force-pushed the fix/#672-false-positive-warning branch from 0d175c2 to ce1d703 Compare September 24, 2024 09:44
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.19%. Comparing base (b966aac) to head (f320878).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/runner/nomad_manager.go 35.29% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   76.14%   76.19%   +0.04%     
==========================================
  Files          43       43              
  Lines        3660     3676      +16     
==========================================
+ Hits         2787     2801      +14     
- Misses        636      640       +4     
+ Partials      237      235       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MrSerth
MrSerth previously approved these changes Sep 24, 2024
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's give this a try. It seems like we are muting the alert if the environment returns within a minute, which should be enough time for any migration to finish.

internal/runner/nomad_manager.go Outdated Show resolved Hide resolved
@MrSerth MrSerth enabled auto-merge (squash) September 24, 2024 16:16
@MrSerth MrSerth merged commit 6cdb2e0 into main Sep 24, 2024
10 checks passed
@MrSerth MrSerth deleted the fix/#672-false-positive-warning branch September 24, 2024 16:22
Copy link

sentry-io bot commented Oct 1, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Environment stopped unexpectedly `` View Issue

Did you find this useful? React with a 👍 or 👎

@MrSerth
Copy link
Member

MrSerth commented Oct 13, 2024

The issue occurred on our staging environment, which we heavily used to prepare the new CodeOcean environment. Hence, we can ignore this occurrence for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants