Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize error handling #400

Merged
merged 2 commits into from
Jun 19, 2024
Merged

harmonize error handling #400

merged 2 commits into from
Jun 19, 2024

Conversation

kkoehn
Copy link
Collaborator

@kkoehn kkoehn commented Jun 18, 2024

Harmonize the raised errors so they can be handled consistently

needed for openHPI/codeharbor#1439

@kkoehn kkoehn requested a review from MrSerth June 18, 2024 21:13
@kkoehn kkoehn self-assigned this Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0e1e117) to head (8079b77).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #400   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         1264      1270    +6     
=========================================
+ Hits          1264      1270    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this PR in conjunction with openHPI/codeharbor#1439 and think it works as expected.

@kkoehn kkoehn merged commit 0af5e2e into main Jun 19, 2024
7 checks passed
@kkoehn kkoehn deleted the harmonize_error_handling branch June 19, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants