refactor: refactor Path tracking to compose #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therajanmaurya
requested changes
Jun 21, 2024
|
|
||
| DisposableEffect(Unit) { | ||
|
|
||
| val notificationReceiver = object : BroadcastReceiver() { |
There was a problem hiding this comment.
Why are you using BroadcastReceiver
There was a problem hiding this comment.
This was previously implemented. it receives datas from path tracking service, but right now path service is not working, so for now, I simply added this so we don't forget this implementation. once path tracking service is fixed, if this receiver is no longer useful, I'll remove it.
There was a problem hiding this comment.
Create a ticket to migrate service in workmanager
feature/path-tracking/src/main/java/com/mifos/feature/path_tracking/PathTrackingScreen.kt
Outdated
Show resolved
Hide resolved
Aditya-gupta99
force-pushed
the
path_tracking
branch
from
20c3d5d to
0088865
Compare
Aditya-gupta99
force-pushed
the
path_tracking
branch
from
0088865 to
cde1986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira MIFOSAC-178
XML Screen
Record_2024-06-18-23-56-26.mp4
Jetpack Compose
Record_2024-06-21-00-30-02.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.