Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Centralize build paths for Android and iOS #38

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

niyajali
Copy link
Collaborator

This pull request includes changes to the GitHub Actions workflow and the Fastlane configuration for both Android and iOS platforms. The main goal is to standardize and simplify the configuration paths and token names.

Changes to GitHub Actions workflow:

Changes to Fastlane configuration:

Update the cache cleanup workflow to run on ubuntu-latest and rename it to 'Cleanup Cache'.
Also, the workflow is triggered on pull request close and workflow dispatch.
Finally, it uses the openMF/mifos-mobile-github-actions cache cleanup action.
Update the cache cleanup workflow to run on ubuntu-latest and rename it to 'Cleanup Cache'.
Also, the workflow is triggered on pull request close and workflow dispatch.
Finally, it uses the openMF/mifos-mobile-github-actions cache cleanup action.
Centralized build paths for Android and iOS by moving them into dedicated configuration objects within `FastlaneConfig`. This improves code organization and maintainability.

- Moved Android build paths to `FastlaneConfig::AndroidConfig::BUILD_PATHS`.
- Moved iOS build paths to `FastlaneConfig::IosConfig::BUILD_CONFIG`.
- Updated Fastfile lanes to use the new centralized paths.
@niyajali niyajali merged commit 6bbf5f7 into openMF:dev Jan 22, 2025
1 check passed
@niyajali niyajali deleted the fix-fastlane branch January 22, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant